Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing theme colors from withing the app at runtime #2340

Closed
a0v0 opened this issue Dec 14, 2022 · 3 comments · Fixed by #2636
Closed

Changing theme colors from withing the app at runtime #2340

a0v0 opened this issue Dec 14, 2022 · 3 comments · Fixed by #2636

Comments

@a0v0
Copy link

a0v0 commented Dec 14, 2022

Similar to how telegram allows you to create custom theme

@cr4zyc4t
Copy link

haha, you must rewrite theming system using React Context API
And not just theming, you can't change language at runtime either because dev team decided that i18n-js is better than react-i18next :))

@Kiura
Copy link

Kiura commented Apr 14, 2023

@cr4zyc4t This looks so bad... since I am rewriting my app (still using ignite), I added a new theming system to support changing the theme at runtime. if I use my method, I have nice UX, but I have trouble keeping the codebase up to date with ignite. Or if I use the default theming system, I have worse UX, but better codebase manageability.

@lindboe
Copy link
Contributor

lindboe commented Sep 16, 2024

Addressed by #2636.

@lindboe lindboe closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants