-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace shell commands with filesystem API in project creation #2817
refactor: replace shell commands with filesystem API in project creation #2817
Conversation
Thanks for this! We will try and get it tested soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some testing but I realized I was testing on the wrong branch, disregard this review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to reproduce the issue with the Expo Router flow on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a test, the Expo Router workflow works on Windows ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
## [10.0.2](v10.0.1...v10.0.2) (2024-10-29) ### Bug Fixes * **boilerplate:** expo-router keyboard provider + theme fix ([#2825](#2825) by [@frankcalise](https://github.com/frankcalise)) ([f82f324](f82f324)) * **cli:** add --legacy-peer-deps for npm users ([#2823](#2823) by [@frankcalise](https://github.com/frankcalise)) ([e59d880](e59d880)) * **cli:** fix issue with workflow prompt values ([#2821](#2821) by [@frankcalise](https://github.com/frankcalise)) ([f2cdd00](f2cdd00)) * **cli:** replace shell commands with filesystem API ([#2817](#2817) by @AsterisMono) ([fd0a418](fd0a418))
🎉 This PR is included in version 10.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please verify the following:
yarn test
jest tests pass with new tests, if relevantyarn lint
eslint checks pass with new code, if relevantyarn format:check
prettier checks pass with new code, if relevantREADME.md
(or relevant documentation) has been updated with your changesDescribe your PR
Fixes #2816.
This PR replaces the
rm
andmv
shell commands in project creation withgluegun (fs-jetpack)
filesystem calls to ensure compatibility with Windows (Since there's nomv
andrm
in Windows CMD).