Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Make installation available from other branches than the infinum repo #749

Closed
dingo-d opened this issue Sep 25, 2023 · 3 comments
Assignees

Comments

@dingo-d
Copy link
Collaborator

dingo-d commented Sep 25, 2023

Currently, the eightshiftLibsRepo is a hardcoded value, which makes installation of different forks for testing purposes, a bit harder (you need to manually change repos). Would it be possible to make this configurable as well? By default, the branch will be the infinum's repo, but by passing the correct repo info, it would be pulled from that repo instead.

const installModifiedComposerDependencies = async (projectPath, branch) => {
return installComposerPackage(projectPath, `${eightshiftLibsRepo}:dev-${branch}`);
};

@iruzevic iruzevic self-assigned this Sep 25, 2023
@iruzevic
Copy link
Member

sure I don't see why not tnx for the suggestion

@dingo-d
Copy link
Collaborator Author

dingo-d commented Sep 25, 2023

The only extra thing that should be changed, for Composer that is, is the addition of the repositories key, but that shouldn't be too hard I think.

https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository

@iruzevic iruzevic changed the title Make installation available from other branches than the infinum repo [FEATURE] - Make installation available from other branches than the infinum repo Oct 23, 2023
@iruzevic
Copy link
Member

iruzevic commented Jun 5, 2024

this is done in the latest release

@iruzevic iruzevic closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants