fix: prevent creating unnecessary threads repeatedly #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
=======================================
Coverage 90.35% 90.35%
=======================================
Files 39 39
Lines 3493 3493
=======================================
Hits 3156 3156
Misses 337 337 ☔ View full report in Codecov by Sentry. |
goznauk
force-pushed
the
patch-1
branch
3 times, most recently
from
65ee74b
to
24103c5
Compare
goznauk
changed the title
goznauk
changed the title
|
@bednar Thank you for your feedback! I have completed all the items in the checklist as requested. Please let me know if there are any other requirements or changes needed for this PR. |
|
@goznauk thanks |
bednar
approved these changes
Sep 21, 2023
|
@bednar any updates for this? |
|
@goznauk, I've added this PR to our backlog. We need to conduct a few manual tests on our end before we can proceed with merging this PR. |
Use ThreadPoolScheduler for WriteApi batch subject instead of TimeoutScheduler. Fixes influxdata#561
|
@goznauk I've tested this PR and everything looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #561
Checklist
pytest testscompletes successfully