Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RuntimeException with InfluxDBException #323

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented May 25, 2017

Fixes #313.

Catched IOExceptions are wrapped in InfluxDBIOException.
@majst01
Copy link
Collaborator

majst01 commented May 25, 2017

Looks good, wait for next release with merging.

@codecov-io
Copy link

Codecov Report

Merging #323 into master will decrease coverage by 0.46%.
The diff coverage is 52.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #323      +/-   ##
===========================================
- Coverage     79.66%   79.2%   -0.47%     
- Complexity      137     139       +2     
===========================================
  Files            11      13       +2     
  Lines           723     731       +8     
  Branches         78      78              
===========================================
+ Hits            576     579       +3     
- Misses          106     111       +5     
  Partials         41      41
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/dto/Query.java 57.89% <0%> (ø) 11 <0> (ø) ⬇️
...rc/main/java/org/influxdb/InfluxDBIOException.java 100% <100%> (ø) 1 <1> (?)
src/main/java/org/influxdb/impl/InfluxDBImpl.java 81.25% <40%> (-1.45%) 42 <0> (-1)
src/main/java/org/influxdb/InfluxDBException.java 66.66% <66.66%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935bc28...4961f31. Read the comment docs.

@majst01 majst01 added this to the 2.7 milestone May 30, 2017
@majst01 majst01 merged commit 546e976 into influxdata:master Jun 13, 2017
@gnebehay
Copy link

nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants