fix issue #485 : MessagePack queries: Exception during parsing InfluxDB version [macOS]

[lxhoan]

No description provided.

[bednar]

Maybe it will be better use some implementation for the Semantic Versioning - semver4j.

The method checkMessagePackSupport will be pretty simple:

private boolean checkMessagePackSupport() {
    Semver version = new Semver(version(), Semver.SemverType.NPM);
    return version.isGreaterThan("1.4");
}

[codecov-io]

Codecov Report

Merging #487 into master will increase coverage by 0.05%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master     #487      +/-   ##
============================================
+ Coverage     87.29%   87.35%   +0.05%     
- Complexity      357      362       +5     
============================================
  Files            24       24              
  Lines          1496     1503       +7     
  Branches        164      167       +3     
============================================
+ Hits           1306     1313       +7     
  Misses          124      124              
  Partials         66       66

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/influxdb/impl/InfluxDBImpl.java	89.78% <91.66%> (+0.19%)	78 <3> (+5)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becbfb5...f134e5b. Read the comment docs.

[lxhoan]

@bednar
I don't think main project maintainers will approve for new dependencies (semver4j) if it not indispensable

[bednar]

@lxhoan I tried the changes on macOS and now the MessagePack queries works

[lxhoan]

there unit test added for the new version checking, it should cover MacOS case and even unrealistic cases

[lxhoan]

@fmachado , please have a look on it, tks

[fmachado]

@lxhoan I know this PR is already merged (and apologies for the delay) but as you requested, I'll add my comments.

[fmachado]

AFAIK, Pattern.compile creates an immutable object so you can reuse it. There is another regular expression that would help you so you don't have to split: (?:(\d+)\.)(\d+). (you can see it working here). You still have to convert it to int, though.