Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imlement issue #439 : Retry capability for writing of BatchPoints #503

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

lxhoan
Copy link
Contributor

@lxhoan lxhoan commented Aug 29, 2018

I believe in the value of support BatchPoints writing with retry
This PR is to expose one method for this purpose

@lxhoan
Copy link
Contributor Author

lxhoan commented Aug 29, 2018

this PR as an alternative to PR #495
This looks simpler because the purpose is exposed directly in InfluxDB interface

Please take a look, tks

@lxhoan lxhoan added this to the 2.13 milestone Aug 29, 2018
@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #503 into master will decrease coverage by 0.22%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #503      +/-   ##
===========================================
- Coverage     87.53%   87.3%   -0.23%     
- Complexity      365     368       +3     
===========================================
  Files            25      25              
  Lines          1500    1513      +13     
  Branches        167     167              
===========================================
+ Hits           1313    1321       +8     
- Misses          120     124       +4     
- Partials         67      68       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/InfluxDB.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/org/influxdb/impl/BatchProcessor.java 98.47% <100%> (+0.01%) 18 <1> (+1) ⬆️
src/main/java/org/influxdb/InfluxDBException.java 88.52% <100%> (-2.39%) 12 <1> (ø)
src/main/java/org/influxdb/impl/InfluxDBImpl.java 89.43% <71.42%> (-0.38%) 80 <2> (+2)
src/main/java/org/influxdb/dto/Query.java 63.15% <0%> (-2.64%) 12% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c5542...3d387c0. Read the comment docs.

@lxhoan
Copy link
Contributor Author

lxhoan commented Aug 30, 2018

Hi @majst01 , @fmachado
What do you think ?

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants