Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for java records #964

Open
eranl opened this issue Nov 26, 2023 · 3 comments · May be fixed by #983
Open

Add support for java records #964

eranl opened this issue Nov 26, 2023 · 3 comments · May be fixed by #983

Comments

@eranl
Copy link
Contributor

eranl commented Nov 26, 2023

It would be nice to read and write data from/to influxdb using java records.

I have implemented such support. Are you interested in a PR?
@majst01
Copy link
Collaborator

majst01 commented Nov 27, 2023 •
edited
Loading

sure, will be a major change as it will drop support for Java 8 which is actually still used by a lot

@eranl
Copy link
Contributor Author

eranl commented Nov 27, 2023

My change compiles on java 8, as it uses reflection for accessing record metadata

@majst01
Copy link
Collaborator

majst01 commented Nov 28, 2023

OK, then open a PR and we can have a look

@eranl eranl linked a pull request Dec 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support java records as measurement classes eranl/influxdb-java
2 participants
@majst01 @eranl