Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default column name to pojo field name, and add allFields mode to Measurement annotation #971

Closed
eranl opened this issue Nov 27, 2023 · 4 comments · Fixed by #972
Closed

Default column name to pojo field name, and add allFields mode to Measurement annotation #971

eranl opened this issue Nov 27, 2023 · 4 comments · Fixed by #972

Comments

@eranl
Copy link
Contributor

eranl commented Nov 27, 2023

It would be nice if @Column could be used without a name, in which case the field name would be used as the column name.

In addition, when a pojo has many fields, it would be nice to be able to annotate it with @Measurement(name = "...", allFields = true) instead of annotating every field with @Column.
Finally, an @Exclude annotation on fields would be helpful, for opting a field out in this mode.

I have implemented such support. Should I submit a PR?
@majst01
Copy link
Collaborator

majst01 commented Nov 28, 2023

Why not simply submit the PR instead ?

@eranl
Copy link
Contributor Author

eranl commented Nov 28, 2023

Because preparing a PR takes work, so I will do it only if desired.

@majst01
Copy link
Collaborator

majst01 commented Nov 29, 2023

I cant help you with this respect, up to you

@eranl eranl mentioned this issue Dec 2, 2023
Merged
@eranl
Copy link
Contributor Author

eranl commented Dec 2, 2023

Posted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@majst01 @eranl