Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the dashboard endpoints document based #15898

Closed
jsteenb2 opened this issue Nov 14, 2019 · 2 comments
Closed

Make the dashboard endpoints document based #15898

jsteenb2 opened this issue Nov 14, 2019 · 2 comments
Assignees
Labels
kind/tech-debt Needs cleanup, will make the developer experience better team/user-tools

Comments

@jsteenb2
Copy link
Contributor

jsteenb2 commented Nov 14, 2019

Pain point: when reading/updating dashboards, its very chatty. When exporting a local dev environments it is very chatty. Each view/cell combo requires a call to read and another to udpate. In testing there was over 240 calls just to add/update 10 dashboards. Would be ideal to extend the current dashboard update to allow for the entire document to be updated at once. In that same light, it would be nice to read the entire dashboard in one call as well.

I'd recommend starting with the read on dashboards to include the nested views for the cell. Then extending the dashboard update to take the entire list of views (not individual), and upsert them over the existing ones. If a nil is provided for charts to the update, then its does nothing, if it is set to a non nil val, it will update, including a non nil empty slice.

this pain became noticeable during work for pkger. feels like a good tech debt candidate.

@jsteenb2 jsteenb2 added team/user-tools kind/tech-debt Needs cleanup, will make the developer experience better labels Nov 14, 2019
@dearyhud
Copy link
Contributor

dearyhud commented Dec 2, 2019

pairing with deniz on the swagger part of this later today, should have this reviewed and merged by EOD

@imogenkinsman
Copy link
Contributor

this is donezo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech-debt Needs cleanup, will make the developer experience better team/user-tools
Projects
None yet
Development

No branches or pull requests

3 participants