Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryBuilder: valid queries with invalid BuilderConfigs cause wonky tab behavior #16169

Closed
russorat opened this issue Dec 9, 2019 · 6 comments · Fixed by #16427
Closed

QueryBuilder: valid queries with invalid BuilderConfigs cause wonky tab behavior #16169

russorat opened this issue Dec 9, 2019 · 6 comments · Fixed by #16427
Assignees
@hoorayimhelping
Labels
kind/bug team/ui

Comments

@russorat
Copy link
Contributor

russorat commented Dec 9, 2019

when you have an editor, with multiple tabs for queries, deleting a tab that you are not currently viewing deletes all the queries.

Kapture 2019-12-09 at 9 57 26
@TCL735 TCL735 self-assigned this Dec 11, 2019
@TCL735
Copy link
Contributor

TCL735 commented Dec 12, 2019

Unable to reproduce

@TCL735 TCL735 removed their assignment Dec 12, 2019
@TCL735
Copy link
Contributor

TCL735 commented Dec 13, 2019

@russorat Can you please try to reproduce this and confirm if this is still an issue?

@russorat
Copy link
Contributor Author

russorat commented Dec 13, 2019 •
edited
Loading

@TCL735 use the attached dashboard to repro. Notice that the JSON has 3 queries, the UI only shows 1, the other two don't show up.

website_monitor (1).json.zip

tried in latest master.

@desa
Copy link
Contributor

desa commented Jan 6, 2020

@TCL735 I've just re-tried this with the dashboard @russorat provided and I have the same issue. I however, do not have the issue when I build a dashboard myself. I think there might be something else going on here.

@alexpaxton
Copy link
Contributor

I ran into this using on a dashboard I imported that @russorat gave me. Looks like some of the dashboard cells show up as having 2 tabs, but when I switch tabs or kill one, the script disappears.

@hoorayimhelping
Copy link
Contributor

hoorayimhelping commented Jan 6, 2020 •
edited
Loading

can reproduce on an existing system graph by editing the query and adding a new tab:

in

this only seems to work on system graphs that were created from the telegraf plugin process.

@hoorayimhelping hoorayimhelping self-assigned this Jan 7, 2020
@hoorayimhelping hoorayimhelping changed the title multiple tabs: deleting the second tab deletes all the queries query builder: advanced mode queries without query builder components have their queries nulled when modifying query tabs Jan 7, 2020
This was referenced Jan 7, 2020
Merged
Open
@hoorayimhelping hoorayimhelping changed the title query builder: advanced mode queries without query builder components have their queries nulled when modifying query tabs QueryBuilder: valid queries without BuilderConfigs cause wonky tab behavior Jan 7, 2020
@hoorayimhelping hoorayimhelping changed the title QueryBuilder: valid queries without BuilderConfigs cause wonky tab behavior QueryBuilder: valid queries with invalid BuilderConfigs cause wonky tab behavior Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoorayimhelping hoorayimhelping

Labels
kind/bug team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show queries built in advanced mode when switching tabs influxdata/influxdb
5 participants
@hoorayimhelping @desa @alexpaxton @russorat @TCL735