Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade process generates a file named config.toml but default used by 2.x is config.yaml #19929

Closed
russorat opened this issue Nov 6, 2020 · 2 comments · Fixed by #19939
Closed
Assignees

Comments

@russorat
Copy link
Contributor

russorat commented Nov 6, 2020

according to the influxd 2.0 help:

	A config file can be provided via the INFLUXD_CONFIG_PATH env var. If a file is
	not provided via an env var, influxd will look in the current directory for a
	config.yaml file. If one does not exist, then it will continue unchanged.

yet the upgrade process generates a file named config.toml and i don't see a reason why (there's no explicit toml syntax)

@danxmoran danxmoran self-assigned this Nov 6, 2020
@danxmoran
Copy link
Contributor

@russorat it looks like the config-parser will handle either config.yaml or config.toml. Do we want to modify the upgrade command to produce YAML, or just update the help text to match the current behavior?

@russorat
Copy link
Contributor Author

russorat commented Nov 6, 2020

The name of the file generated should match the default name we look for when starting 2.0. Specifically: influxd will look in the current directory for a config.yaml file

you are saying it will find either a config.toml or a config.yaml by default? if that's the case, we can simply update the text in the help message,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants