fix: throw error when adding fields to non-existent table in WAL #25525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also added in some helpers to the wal crate that were previously added to pro.
praveen-influx
approved these changes
Nov 8, 2024
| ) -> WalContents { | ||
| WalContents { | ||
| min_timestamp_ns, | ||
| max_timestamp_ns, |
There was a problem hiding this comment.
Thanks for embedding the unit ns, really helps when reading the code without full context.
There was a problem hiding this comment.
Yeah, we should do that everywhere in the code where we don't have a typed time.
pauldix
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25524
In addition to throwing an error when an
AddFieldsoperation is applied for a table that does not exist, this PR adds some helper methods to theinfluxdb3_walcrate for creating WAL operations that were previously added in pro.A test was added to check for the failure condition.