Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TLS integration test #109

Open
crepererum opened this issue Feb 22, 2022 · 2 comments
Open

Enable TLS integration test #109

crepererum opened this issue Feb 22, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@crepererum
Copy link
Collaborator

crepererum commented Feb 22, 2022 •
edited
Loading

We already have a TLS integration test here

rskafka/tests/client.rs

Lines 73 to 75 in 3af1939

// Disabled as currently no TLS integration tests
#[ignore]
#[tokio::test]

but it is disabled because our CI doesn't set up any form of TLS. Would be nice if we could get this to work. Ideally the test would be gated by some environment variable like TLS_ENDPOINT so that developers can still run a rather simple cargo test locally.
@crepererum crepererum added the good first issue Good for newcomers label Feb 22, 2022
@toondaey
Copy link
Contributor

toondaey commented Dec 1, 2023

Would it be possible to switch ci to github actions?

@crepererum
Copy link
Collaborator Author

@toondaey what would be the advantage of switching?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crepererum @toondaey