-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter for plugin documentation #10488
Comments
next steps: @reimda to bring the final PR(s) home and land 'em! |
Here's a summary of related work: PRs merged:
PRs to be merged:
no PR yet:
We're currently moving plugin sample configs to be in separate files (#11136 and related). Since that task also requires touching every readme, it makes sense not to do it at the same time as cleaning up the readme linter errors. Moving sample configs should be done in a few days. When it's done I'll continue cleaning up readme linter errors. |
FYI @srebhan has completed these. |
@reimda I think this is done? |
Yes it's done |
Documentation of each plugin is in readme.md in the plugin folder. To make them easier to use, we try to keep the structure of the readme.md files similar for all plugins. They should always include a short description of the purpose of the plugin, a sample of its toml configuration, and a description of the plugin's metric format. They can optionally have compatibility notes and other sections.
Since many people edit the plugin docs it is hard to keep the structure similar. Let's add a linter that parses the markdown and checks that the expected sections are present. Since the sample toml config is also kept in the plugin's source code, the linter could also check that the two copies match.
There are other things a linter could do, such as check that all the toml settings that the plugin accepts are documented in the sample config.
This should also make code reviews of plugin changes more simple and help contributors of new plugins know what is required for documentation
The text was updated successfully, but these errors were encountered: