Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: custom arguments to pgrep for procstat #2505

Open
phemmer opened this issue Mar 7, 2017 · 4 comments
Open

Feature request: custom arguments to pgrep for procstat #2505

phemmer opened this issue Mar 7, 2017 · 4 comments
Labels
area/procstat help wanted Request for community participation, code, contribution size/m 2-4 day effort

Comments

@phemmer
Copy link
Contributor

phemmer commented Mar 7, 2017

Proposal:

For advanced use cases, it would be nice to be able to provide custom arguments to the pgrep command used by the procstat input plugin.

Current behavior:

No such option

Desired behavior:

[[inputs.procstat]]
  pgrep = ["-w","-x","foo"]

Use case: [Why is this important (helps with prioritizing requests)]

In my specific use case, and in the example I gave above, we want -w so that we can monitor threads. We also need -x so that pgrep doesn't erroneously match the wrong process. The -x is just a nicety though, and we can match other ways. The important bit which we have no workaround for is the -w. But a generic way to provide custom arguments makes it more flexible so users can do whatever they want.

Ref: #1828 #1723 #932

@sparrc sparrc added this to the Future Milestone milestone Mar 8, 2017
@sparrc
Copy link
Contributor

sparrc commented Mar 8, 2017

I agree this would be good to have

@danielnelson
Copy link
Contributor

So long as we are exec'ing pgrep, and not some mythical cross platform pid finding library, I agree we should do this.

@danielnelson danielnelson modified the milestones: 1.4.0, Future Milestone Apr 20, 2017
@danielnelson danielnelson modified the milestones: 1.4.0, 1.5.0 Aug 14, 2017
@danielnelson danielnelson modified the milestones: 1.5.0, 1.6.0 Nov 30, 2017
@russorat russorat removed this from the 1.6.0 milestone Jan 26, 2018
@adityacj
Copy link

Any ETA on this?

@powersj powersj added help wanted Request for community participation, code, contribution size/m 2-4 day effort labels Aug 16, 2022
@srebhan srebhan added the upstream bug or issues that rely on dependency fixes label Sep 8, 2023
@srebhan srebhan removed the upstream bug or issues that rely on dependency fixes label Nov 22, 2023
@tguenneguez
Copy link
Contributor

Good morning,
Why don't you use in your patterns:
“^toto$”?
Will it be the same?
Thanks
Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/procstat help wanted Request for community participation, code, contribution size/m 2-4 day effort
Projects
None yet
Development

No branches or pull requests

8 participants