Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum processor should also support tags #5033

Closed
robcowart opened this issue Nov 24, 2018 · 6 comments · Fixed by #5855
Closed

enum processor should also support tags #5033

robcowart opened this issue Nov 24, 2018 · 6 comments · Fixed by #5855
Assignees
Labels
feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@robcowart
Copy link
Contributor

Feature Request

As documented in #4616 the enum processor should support both fields and tags.

Proposal:

Support for tags should be added.

Current behavior:

In its current v1.9.0 form it only supports fields, not tags.

Desired behavior:

It should also support tags.

Use case: [Why is this important (helps with prioritizing requests)]

Here is an example where the SNMP object hrStorageType, which has a value that is an OID, can be made more user-friendly.

[[processors.enum]]
  [[processors.enum.mapping]]
    tag = "hrStorageType"
    [processors.enum.mapping.value_mappings]
      ".1.3.6.1.2.1.25.2.1.1" = "Other"
      ".1.3.6.1.2.1.25.2.1.2" = "RAM"
      ".1.3.6.1.2.1.25.2.1.3" = "Virtual Memory"
      ".1.3.6.1.2.1.25.2.1.4" = "Fixed Disk"
      ".1.3.6.1.2.1.25.2.1.5" = "Removable Disk"
      ".1.3.6.1.2.1.25.2.1.6" = "Floppy Disk"
      ".1.3.6.1.2.1.25.2.1.7" = "Compact Disc"
      ".1.3.6.1.2.1.25.2.1.8" = "RAM Disk"
      ".1.3.6.1.2.1.25.2.1.9" = "Flash Memory"
      ".1.3.6.1.2.1.25.2.1.10" = "Network Disk"
@glinton glinton added the feature request Requests for new plugin and for new features to existing plugins label Nov 27, 2018
@glinton
Copy link
Contributor

glinton commented Nov 27, 2018

Great use case, thanks for submitting this

@ferrerogg
Copy link

I have a similar problem with diskio plugin and this feature would be very useful

@morph027
Copy link

morph027 commented Apr 4, 2019

Same applies to disk input for me ;)

@glinton
Copy link
Contributor

glinton commented May 15, 2019

If anyone get's a chance and would like, this is a build (64 bit) where tags are supported in the enum processor. We'd love feedback:

@prandelicious
Copy link

prandelicious commented May 27, 2019

Does this work if the target/destination is a tag instead of field? For example, I'm looking at mapping these URLs to a host:

[processors.enum.mapping.value_mappings] "service:jmx:rmi:///jndi/rmi://10.1.xx.xx:4091/jmxrmi" = "host01" "service:jmx:rmi:///jndi/rmi://10.1.xx.xx:5091/jmxrmi" = "host01" "service:jmx:rmi:///jndi/rmi://10.1.xx.xx:6091/jmxrmi" = "host01" "service:jmx:rmi:///jndi/rmi://10.1.xx.xx:6093/jmxrmi" = "host01" "service:jmx:rmi:///jndi/rmi://10.1.xx.xx:8091/jmxrmi" = "host01" "service:jmx:rmi:///jndi/rmi://10.1.xx.yy:5091/jmxrmi" = "host03" "service:jmx:rmi:///jndi/rmi://10.1.xx.yy:6091/jmxrmi" = "host03" "service:jmx:rmi:///jndi/rmi://10.1.xx.yy:6093/jmxrmi" = "host03" "service:jmx:rmi:///jndi/rmi://10.1.xx.yy:6095/jmxrmi" = "host03" "service:jmx:rmi:///jndi/rmi://10.1.xx.yy:6097/jmxrmi" = "host03" "service:jmx:rmi:///jndi/rmi://10.1.xx.yy:6099/jmxrmi" = "host03"

@danielnelson
Copy link
Contributor

#5855 keeps the tag/field status of the source key, but you can follow up the processor with the converter processor if you need to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants