Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using floating point numbers in statsd percentiles #5527

Closed
Pitxyoki opened this issue Mar 4, 2019 · 1 comment
Closed

Allow using floating point numbers in statsd percentiles #5527

Pitxyoki opened this issue Mar 4, 2019 · 1 comment
Labels
area/statsd feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@Pitxyoki
Copy link
Contributor

Pitxyoki commented Mar 4, 2019

Feature Request

Opening a feature request kicks off a discussion.

Proposal:

We should be able to define percentiles with decimal places when using statsd as the source of input.

Current behavior:

If we try to define a percentile array with floating point numbers, for example: [99.0, 99.9, 99.99, 100.0], Telegraf won't even start and will stop with the following error:

2019-03-04T21:04:26Z I! Starting Telegraf 1.9.2
2019-03-04T21:04:26Z I! Using config file: /etc/telegraf/telegraf.conf
2019-03-04T21:04:26Z E! [telegraf] Error running agent: Error parsing /etc/telegraf/telegraf.conf, line 1579: statsd.Statsd.Percentiles: `int' is not float32 or float64

Desired behavior:

We should be able to define more fine-grained percentiles.

Use case:

After getting more than 100 data points per submission interval, it becomes important to see percentiles between 99.0 and 100.0.

@glinton glinton added feature request Requests for new plugin and for new features to existing plugins area/statsd labels Mar 4, 2019
@danielnelson danielnelson added this to the 1.12.0 milestone Jul 9, 2019
@danielnelson
Copy link
Contributor

Closed in #5572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/statsd feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

3 participants