Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision timestamp for jti_openconfig_telemetry input plugin #5853

Closed
door7302 opened this issue May 14, 2019 · 1 comment · Fixed by #7762
Closed

Precision timestamp for jti_openconfig_telemetry input plugin #5853

door7302 opened this issue May 14, 2019 · 1 comment · Fixed by #7762
Assignees
Labels
area/agent feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@door7302
Copy link
Contributor

Feature Request

Allow to set the precision of timestamp set by the input jti_openconfig_telemetry.
Currently timestamp precision is in ns. It could be interesting to have precision in second to avoid ms jitter between sensor paths.

Opening a feature request kicks off a discussion.

Proposal:

Allow to set :

precision: "s | ms | us | ns"

Current behavior:

Send ns timestamp

Desired behavior:

Still sending ns timestamp (epoch) but with less precision that a ns. Ex.

Before you have timestamp like that :

1557755590589715534

With precision="s" you should have something like :

1557755590000000000

Use case:

If I request to Junos from telegraf the sensor : /interfaces/interface

I could receive from the network equipment :

/interfaces/interface/state/counters/xxxx with timestamp 1557755590589715534
/interfaces/interface/state/cdescription with timestamp 1557755590685780881

To aggregate (merge) those 2 values in a third one on influxdb based on time it's more difficult.
It could help to have at the output of telegraf :

/interfaces/interface/state/counters/xxxx with timestamp 1557755590000000000
/interfaces/interface/state/cdescription with timestamp 1557755590000000000

@danielnelson
Copy link
Contributor

It may be worth adding a precision option for all input/aggregator plugins that would override the global agent precision. Unlike the agent precision it would apply to both "service inputs", like jti_openconfig_telemetry, and regular polling inputs.

@danielnelson danielnelson self-assigned this May 15, 2019
@danielnelson danielnelson added area/agent feature request Requests for new plugin and for new features to existing plugins labels May 15, 2019
@danielnelson danielnelson added this to the 1.15.0 milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants