Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.snmp): Avoid sending a nil to gosmi's GetEnumBitsFormatted #15743

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Aug 14, 2024

Summary

There is an upstream PR to resolve an issue when a nil value is passed. However that PR has not been looked at or merged. As such, this attempts to catch that scenario in Telegraf first.

See: sleepinggenius2/gosmi#45

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15200

There is an upstream PR to resolve an issue when a nil value is passed.
However that PR has not been looked at or merged. As such, this attempts
to catch that scenario in Telegraf first.

See: sleepinggenius2/gosmi#45

fixes: influxdata#15200
@telegraf-tiger telegraf-tiger bot added area/snmp fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 14, 2024
@powersj powersj mentioned this pull request Aug 14, 2024
@powersj powersj added the waiting for response waiting for response from contributor label Aug 16, 2024
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@powersj
Copy link
Contributor Author

powersj commented Aug 21, 2024

@llamafilm have you had a chance to confirm this fix?

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Aug 21, 2024
@powersj powersj added the waiting for response waiting for response from contributor label Aug 21, 2024
@llamafilm
Copy link
Contributor

No. I'm still trying to figure out how to reproduce the crash reliably, before I try this new build.
Some other issues are getting in the way, like the one I posted on slack yesterday.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Aug 21, 2024
@powersj powersj removed their assignment Aug 24, 2024
@srebhan
Copy link
Member

srebhan commented Aug 26, 2024

@llamafilm please let us know if you were able to test. I would like to include this in our next release which is due on September 9th, so it would be good to have your say before...

@srebhan srebhan self-assigned this Aug 26, 2024
@srebhan srebhan added the waiting for response waiting for response from contributor label Aug 28, 2024
@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed waiting for response waiting for response from contributor labels Sep 5, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Sep 5, 2024
@DStrand1 DStrand1 merged commit 8356196 into influxdata:master Sep 5, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNMP panic
5 participants