-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.snmp): Avoid sending a nil to gosmi's GetEnumBitsFormatted #15743
Conversation
There is an upstream PR to resolve an issue when a nil value is passed. However that PR has not been looked at or merged. As such, this attempts to catch that scenario in Telegraf first. See: sleepinggenius2/gosmi#45 fixes: influxdata#15200
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me
@llamafilm have you had a chance to confirm this fix? |
No. I'm still trying to figure out how to reproduce the crash reliably, before I try this new build. |
@llamafilm please let us know if you were able to test. I would like to include this in our next release which is due on September 9th, so it would be good to have your say before... |
Summary
There is an upstream PR to resolve an issue when a nil value is passed. However that PR has not been looked at or merged. As such, this attempts to catch that scenario in Telegraf first.
See: sleepinggenius2/gosmi#45
Checklist
Related issues
fixes: #15200