Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.kinesis): Honor the configured endpoint #15781

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

mskonovalov
Copy link
Contributor

Summary

When trying to run telegraf locally in docker-compose and trying to connect to localstack kinesis, it tries to call public aws url instead of one in the config

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@mskonovalov mskonovalov changed the title support kinesis endpoint feat: support kinesis endpoint Aug 27, 2024
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 27, 2024
@srebhan
Copy link
Member

srebhan commented Aug 27, 2024

@mskonovalov please sign the CLA so we can review your PR!

@srebhan srebhan self-assigned this Aug 27, 2024
@mskonovalov
Copy link
Contributor Author

just adding the same code to the input plugin as well

@srebhan
Copy link
Member

srebhan commented Aug 28, 2024

Thanks @mskonovalov! Could you please split the input and output change into a separate PR? It's easier to keep track of things this way...

@mskonovalov
Copy link
Contributor Author

Thanks @mskonovalov! Could you please split the input and output change into a separate PR? It's easier to keep track of things this way...

done @srebhan
2nd PR is #15788

@mskonovalov mskonovalov changed the title feat: support kinesis endpoint feat: support endpoint in kinesis output plugin Aug 29, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan changed the title feat: support endpoint in kinesis output plugin fix(outputs.kinesis): Honor the configured endpoint Aug 29, 2024
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Aug 29, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mskonovalov for fixing this!

@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Aug 29, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Aug 29, 2024
@DStrand1 DStrand1 merged commit 8866399 into influxdata:master Aug 29, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Aug 29, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants