Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Legend: existing cells should not turn on static legend #1666

Closed
TCL735 opened this issue Jun 9, 2021 · 0 comments · Fixed by #1684
Closed

Static Legend: existing cells should not turn on static legend #1666

TCL735 opened this issue Jun 9, 2021 · 0 comments · Fixed by #1684
Assignees
Labels
enhancement New feature or request kind/tech-debt team/dumplings More suited for the Dumplings squad of the UI team team/ui

Comments

@TCL735
Copy link
Contributor

TCL735 commented Jun 9, 2021

When Static Legend goes to production as a new feature, existing cells should not have a static legend turned on automatically as this is very jarring for users. And requiring users to turn off static legends for existing cells is too burdensome.

After this is merged, the following steps will confirm in Tools:

  • turn off the feature flag staticLegend in ConfigCat
  • create and save some cells (they won't have any static legends as it will be impossible with the feature flag off)
  • turn on the feature flag staticLegend in ConfigCat (just for Tools)
  • visually inspect the cells previously created to ensure they do not have a static legend (since none were created) automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/tech-debt team/dumplings More suited for the Dumplings squad of the UI team team/ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant