Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fault tolerance for execution of event loops in background threads #1025

Open
5 tasks
soareschen opened this issue Jun 1, 2021 · 0 comments
Open
5 tasks
Labels
O: code-hygiene Objective: cause to improve code hygiene O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@soareschen
Copy link
Contributor

Crate

relayer

Summary of Bug

In the loops of background threads such as ChainRuntime, the loop may break via the ? operator, which short circuits the function and return an error result. When that happens, the current behavior is only to print out an error message.

Such errors should not be ignored and instead should be handled by either:

  • Handle the error from some supervisor process that restart the thread.
  • Propagate the error to the top level application so that the program is crashed instead of continue operating with errors.

Version

a1e95e1

Acceptance Criteria

Errors in background loops are no longer ignored.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the Backlog milestone Aug 3, 2021
@adizere adizere added O: code-hygiene Objective: cause to improve code hygiene O: new-feature Objective: cause to add a new feature or support labels Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: code-hygiene Objective: cause to improve code hygiene O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Development

No branches or pull requests

2 participants