Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hermes keys add and hermes keys restore are redundant #1075

Closed
5 tasks
greg-szabo opened this issue Jun 10, 2021 · 1 comment · Fixed by #2251
Closed
5 tasks

hermes keys add and hermes keys restore are redundant #1075

greg-szabo opened this issue Jun 10, 2021 · 1 comment · Fixed by #2251
Assignees
Labels
A: good-first-issue Admin: good for newcomers I: CLI Internal: related to the relayer's CLI O: security Objective: cause to enhance security and improve safety O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@greg-szabo
Copy link
Member

Crate

relayer-cli

Summary

We could reduce the number of commands supported under hermes keys.

Problem Definition

With the --hd-path command implemented for both keys add and keys restore, the two commands essentially require the same parameters but in a different format. One requests the mnemonic from a file, the other from the stdin.

It would simpler to only maintain one code base instead.

Proposal

a.) Merge the two commands into add that has both the -f and the -m command. They are interchangeable but only one can be defined.
b.) Come up with other solutions so there's only one code that supports adding/restoring keys.

Acceptance Criteria

Done: The process of adding/restoring keys is straightforward.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the 08.2021 milestone Jun 24, 2021
@adizere adizere modified the milestones: 08.2021, 11.2021 Aug 3, 2021
@mircea-c
Copy link

mircea-c commented Sep 2, 2021

I'd like to add that the -m flag used in the restore command is very unsafe. The mnemonic has to be pasted in the command line and then is possibly saved to shell history file. I would eliminate this completely in favour of reading the mnemonics from a file or from stdin.

@adizere adizere added I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product A: good-first-issue Admin: good for newcomers O: security Objective: cause to enhance security and improve safety and removed backburner labels Oct 21, 2021
@adizere adizere modified the milestones: 11.2021, Backlog Nov 2, 2021
@ljoss17 ljoss17 self-assigned this May 31, 2022
@adizere adizere modified the milestones: Backlog, v1.0.0 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: good-first-issue Admin: good for newcomers I: CLI Internal: related to the relayer's CLI O: security Objective: cause to enhance security and improve safety O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

4 participants