Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection & Channel workers never quit #1115

Closed
5 of 6 tasks
adizere opened this issue Jun 22, 2021 · 0 comments
Closed
5 of 6 tasks

Connection & Channel workers never quit #1115

adizere opened this issue Jun 22, 2021 · 0 comments
Labels
A: question Admin: further information is requested I: logic Internal: related to the relaying logic O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@adizere
Copy link
Member

adizere commented Jun 22, 2021

Crate

relayer

Summary

A connection (informalsystems/ibc-rs#1019) or channel worker starts up when a chain emits a specific events of type handshake (e.g., conn open init, or chan open init). If Hermes is running passively (hermes start) with strategy = all and one of these workers start, then the worker takes care of triggering any further steps needed to complete the open handshake protocols. After complete the handshake, however, the worker never quits, it just sits in an infinite loop. It's not clear if the worker will ever have any other tasks to complete, but at a minimum there should be a mechanism to allow the worker to detect when its job is done & exit gracefully.

Acceptance Criteria

  • the supervisor as well as the workers for connection & channel handle gracefully the end-of-life of these workers

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added O: new-feature Objective: cause to add a new feature or support A: question Admin: further information is requested I: logic Internal: related to the relaying logic labels Jun 22, 2021
@adizere adizere added this to the 08.2021 milestone Jun 22, 2021
@ancazamfir ancazamfir mentioned this issue Jun 22, 2021
7 tasks
@adizere adizere modified the milestones: 08.2021, 10.2021 Aug 3, 2021
@adizere adizere modified the milestones: 10.2021, Backlog Sep 30, 2021
@adizere adizere modified the milestones: Backlog, v2 Jun 1, 2022
@adizere adizere modified the milestones: v2, v1.1 Jun 29, 2022
@romac romac closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: question Admin: further information is requested I: logic Internal: related to the relaying logic O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Development

No branches or pull requests

2 participants