Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default_gas setting to be used for submitting a tx when tx simulation fails #1457

Closed
5 tasks done
Tracked by #1418
romac opened this issue Oct 13, 2021 · 0 comments · Fixed by #1419
Closed
5 tasks done
Tracked by #1418

Add a default_gas setting to be used for submitting a tx when tx simulation fails #1457

romac opened this issue Oct 13, 2021 · 0 comments · Fixed by #1419
Assignees
Labels
I: configuration Internal: related to Hermes configuration I: logic Internal: related to the relaying logic
Milestone

Comments

@romac
Copy link
Member

romac commented Oct 13, 2021

Crate

ibc-relayer

Summary

Add a default_gas setting to be used for submitting a tx when tx simulation fails.

Problem Definition

Currently, when the tx simulation fails we fall back on the max_gas config param to compute the fee for the tx before actually submitting it. Because tx simulation can fail for many reasons, and this happens somewhat often, doing so can very quickly drain the wallets of operators with a high max_gas .

Proposal

Add a default_gas setting to be used instead of max_gas for submitting a tx when tx simulation fails.

The idea is that this default_gas setting would much lower than the max_gas and would be typically enough for submitting 95-99% of txs.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added this to the 10.2021 milestone Oct 13, 2021
@romac romac self-assigned this Oct 13, 2021
@romac romac added I: configuration Internal: related to Hermes configuration I: logic Internal: related to the relaying logic labels Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: configuration Internal: related to Hermes configuration I: logic Internal: related to the relaying logic
Projects
None yet
1 participant