Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use derive_more for cleaner Display implementations #175

Closed
greg-szabo opened this issue Jul 28, 2020 · 1 comment
Closed

Use derive_more for cleaner Display implementations #175

greg-szabo opened this issue Jul 28, 2020 · 1 comment
Milestone
Backlog

Comments

@greg-szabo
Copy link
Member

We could perhaps consider using the derive_more crate to make this more readable. Downside is that it pulls in quite a few dependencies, though they are compile-time only. This can be mitigated a bit by only using the features we need.

Originally posted by @romac in #174 (comment)
@romac romac changed the title Use derive_more for cleaner struct implementations Use derive_more for cleaner Display implementations Jul 28, 2020
@ancazamfir ancazamfir added this to the v0.0.4 milestone Aug 14, 2020
@ancazamfir ancazamfir modified the milestones: v0.0.4, v0.0.5 Sep 9, 2020
@ancazamfir ancazamfir modified the milestones: v0.0.5, v0.0.7 Oct 21, 2020
@adizere adizere modified the milestones: v0.1.0, v0.1.2 Jan 6, 2021
@adizere
Copy link
Member

adizere commented Jan 6, 2022

Will take the suggestion here into account when fixing #1559.

@adizere adizere closed this as completed Jan 6, 2022
@adizere adizere mentioned this issue Jan 6, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@adizere @ancazamfir @greg-szabo