Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate async traits #177

Closed
greg-szabo opened this issue Jul 28, 2020 · 1 comment
Closed

Investigate async traits #177

greg-szabo opened this issue Jul 28, 2020 · 1 comment
Milestone

Comments

@greg-szabo
Copy link
Member

Not very important right now, but just pointing out that async methods are somewhat supported on stable Rust via the async-trait crate. This crate sometimes yield weird compile-time errors and incurs a boxing of the returned Future but has otherwise worked pretty well for us in the past.

Originally posted by @romac in #174 (comment)

@ancazamfir ancazamfir added this to the v0.0.4 milestone Aug 14, 2020
@ebuchman ebuchman modified the milestones: v0.0.4, v0.0.5 Aug 28, 2020
@romac
Copy link
Member

romac commented Oct 15, 2020

We already use the async-trait crate in many places in tendermint-rs and in ibc-rs. I think we can close this as it's worked pretty well for us so far.

@romac romac closed this as completed Oct 15, 2020
@adizere adizere modified the milestones: v0.0.5, v0.0.4 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants