Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of query pagination #1816

Open
1 of 6 tasks
seanchen1991 opened this issue Jan 26, 2022 · 0 comments
Open
1 of 6 tasks

Take advantage of query pagination #1816

seanchen1991 opened this issue Jan 26, 2022 · 0 comments
Labels
I: logic Internal: related to the relaying logic O: code-hygiene Objective: cause to improve code hygiene O: performance Objective: cause to improve performance
Milestone

Comments

@seanchen1991
Copy link
Contributor

seanchen1991 commented Jan 26, 2022

Crate

ibc_rs::relayer

Summary

In #1705, pagination of queries was used to reduce some redundant network calls. We should look at other ways in which query pagination can be used to limit unnecessary network calls.

Problem Definition

This should help to improve relayer performance. At the moment we are also simply not taking advantage of query pagination.

Proposal

Currently any query where pagination can be toggled on merely utilizes pagination::all(). We can search for all of these spots and evaluate whether it makes sense to limit the number of results returned from the query.

Acceptance Criteria

Evaluate and update all appropriate queries being performed in the relayer to take advantage of query pagination.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added O: code-hygiene Objective: cause to improve code hygiene O: performance Objective: cause to improve performance I: logic Internal: related to the relaying logic labels Feb 1, 2022
@adizere adizere added this to the v0.11.1 milestone Feb 1, 2022
@romac romac modified the milestones: v0.11.1, v0.12.0 Feb 2, 2022
@adizere adizere modified the milestones: v0.12.0, v1.0.0 Feb 15, 2022
@adizere adizere removed the P-medium label Feb 25, 2022
@adizere adizere mentioned this issue Feb 25, 2022
5 tasks
@adizere adizere modified the milestones: v1.0.0, Backlog May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: logic Internal: related to the relaying logic O: code-hygiene Objective: cause to improve code hygiene O: performance Objective: cause to improve performance
Projects
None yet
Development

No branches or pull requests

3 participants