Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packet filtering based on whether packet contains relaying fee #1966

Closed
5 tasks
Tracked by #1168 ...
soareschen opened this issue Mar 16, 2022 · 0 comments · Fixed by #3133
Closed
5 tasks
Tracked by #1168 ...

Allow packet filtering based on whether packet contains relaying fee #1966

soareschen opened this issue Mar 16, 2022 · 0 comments · Fixed by #3133
Assignees
Labels
O: ics29-fee Objective: Fee middleware support
Milestone

Comments

@soareschen
Copy link
Contributor

soareschen commented Mar 16, 2022

Summary

Relayer operators should be able to specify packet filter to only relay incentivized packets with certain minimum fee. Depending on the type of relaying, the relayer needs to filter based on either the receive fee, ack fee, or timeout fee fields.

A complication is that if packet fee is added afterward through MsgPayPacketFeeAsync, the relayer needs to re-filter the relevant packet and perform relaying if the packet now contains sufficient fee. Implementation needs to be cautious of duplicate relaying of the same packet caused by the trigger from MsgPayPacketFeeAsync.

We may want to make use of new GRPC APIs such as IncentivizedPacketsForChannel. The relayer should also listen to new event types like EventTypeIncentivizedPacket so that it can detect packets with new fee added via MsgPayPacketFeeAsync.

Acceptance Criteria

When the relayer is started with custom fee packet filter, packets without fees or packets with insufficient fees should not get relayed. If fees are added to the packet afterward with MsgPayPacketFeeAsync, then the packet should be relayed by the relayer.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@soareschen soareschen added the O: ics29-fee Objective: Fee middleware support label Mar 16, 2022
@soareschen soareschen added this to the v0.14.0 milestone Mar 16, 2022
@adizere adizere modified the milestones: v0.14.0, v0.15.0 Mar 23, 2022
@adizere adizere modified the milestones: v0.15.0, v1.0.0, v1.2 May 24, 2022
@adizere adizere modified the milestones: v1.2, v1.4 Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: ics29-fee Objective: Fee middleware support
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants