Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hermes config validate reports success when no config #2143

Closed
5 tasks
plafer opened this issue Apr 26, 2022 · 1 comment · Fixed by #2255
Closed
5 tasks

hermes config validate reports success when no config #2143

plafer opened this issue Apr 26, 2022 · 1 comment · Fixed by #2255
Assignees
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews I: CLI Internal: related to the relayer's CLI I: configuration Internal: related to Hermes configuration O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented Apr 26, 2022

Summary of Bug

When no config file is present at ~/.hermes/config.toml, hermes config validate prints the following errors, and then indicates success.

% hermes config validate
2022-04-26T14:26:37.372557Z ERROR ThreadId(01) could not find configuration file at '/Users/plafer/.hermes/config.toml'
2022-04-26T14:26:37.372605Z ERROR ThreadId(01) for an example, please see https://hermes.informal.systems/config.html#example-configuration-file
Success: "configuration is valid"

Version

v0.13

Steps to Reproduce

  1. ensure no file is present at ~/.hermes/config.toml
  2. Run hermes config validate
  3. Notice that the command succeeds

Acceptance Criteria

hermes config validate does not succeed when no config file is present.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer
Copy link
Contributor Author

plafer commented Apr 26, 2022

Additionally, if there is an empty file, the command reports success as well. IIUC, this should fail as not all required fields are present.

@romac romac added I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product I: configuration Internal: related to Hermes configuration A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Apr 28, 2022
@adizere adizere added this to the v1.0.0 milestone May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews I: CLI Internal: related to the relayer's CLI I: configuration Internal: related to Hermes configuration O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

4 participants