Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send a client update if consensus state already exists #2211

Closed
5 tasks
ancazamfir opened this issue May 13, 2022 · 1 comment
Closed
5 tasks

Don't send a client update if consensus state already exists #2211

ancazamfir opened this issue May 13, 2022 · 1 comment
Milestone

Comments

@ancazamfir
Copy link
Collaborator

Summary

With the fix for #2087, because multiple batches perform client update at same height we see the following warnings:

2022-05-13T11:09:32.471130Z  WARN ThreadId(290) packet_cmd{src_chain=ibc-0 src_port=transfer src_channel=channel-1 dst_chain=ibc-1}:clear:schedule_recv_packet_and_timeout_msgs{h=Some(Height { revision: 0, height: 599 })}:schedule{odata=oHMVz0CGiB ->Destination @0-599; len=50}: [ibc-0 -> ibc-1:07-tendermint-1] resolving trusted height from the full list of consensus state heights for target height 0-600; this may take a while

Then things proceed and work is wasted for an updated that it is not needed.

Problem Definition

Proposal

Add a check in update client for client_latest_height == target_height and make it a noop in this case.

Acceptance Criteria

The warning above is not seen and the client update is not issued if the chain already has the consensus state.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the refactor sink milestone Jul 26, 2022
@romac
Copy link
Member

romac commented Mar 7, 2024

Done in #3555

@romac romac closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants