Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional flags --counterparty-chain and --verbose to hermes query connections #2310

Closed
5 tasks
ljoss17 opened this issue Jun 16, 2022 · 0 comments · Fixed by #2391
Closed
5 tasks

Add optional flags --counterparty-chain and --verbose to hermes query connections #2310

ljoss17 opened this issue Jun 16, 2022 · 0 comments · Fixed by #2391
Assignees
Milestone

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Jun 16, 2022

Summary

Adding two optional flags to Hermes query connections command. One flag to filter counterparty chains and one to enable more verbose output.

Problem Definition

Following the review comment for the ADR providing recommendations for Hermes commands, #2306 (comment), the query connections requires the implementation of two optional flags.

This would allow to filter some queried connections as well as making it so that the query connections has similar parameters as the query channels command.

Proposal

The query connections command should take the optional flags [--counterparty-chain <COUNTERPARTY_CHAIN_ID>] [--verbose].
The flag [--counterparty-chain <COUNTERPARTY_CHAIN_ID>] is used to filter the connections which have the counterparty chain as one end point.
The flag [--verbose] is used to enable a more verbose output.

Acceptance Criteria

  • [--counterparty-chain <COUNTERPARTY_CHAIN_ID>] [--verbose] are implemented for the create connections command.
  • Hermes guide is updated with the new optional flags.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 self-assigned this Jul 11, 2022
@romac romac added this to the v1.0.0 milestone Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants