Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling hermes add keys can overwrite a key without any confirmation or warning #2375

Closed
1 of 5 tasks
AlianBenabdallah opened this issue Jul 5, 2022 · 0 comments · Fixed by #2378
Closed
1 of 5 tasks
Assignees
Labels
I: CLI Internal: related to the relayer's CLI
Milestone

Comments

@AlianBenabdallah
Copy link
Contributor

AlianBenabdallah commented Jul 5, 2022

Summary of Bug

It is possible to overwrite an existing key with hermes add without any confirmation or warning. It would make sense that an add subcommand would only add a key and not modify one, potentially by mistake.

Version

v0.15.0 (guide version)
Possibly present in every version

Steps to Reproduce

gaiad keys add testkey --output json > key_seed.json
gaiad keys add testkey --output json > key_seed2.json
// Note that the two keys are different except for their name.
hermes keys add ibc-0 -f key_seed.json
hermes keys add ibc-0 -f key_seed2.json

Acceptance Criteria

hermes keys add issues a warning if a key already exists and ask for confirmation or a new command hermes modify.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added the I: CLI Internal: related to the relayer's CLI label Jul 5, 2022
@romac romac added this to the v1.0.0 milestone Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

4 participants