Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove height() from IbcEvent #2539

Closed
plafer opened this issue Aug 8, 2022 · 0 comments · Fixed by #2542
Closed

Remove height() from IbcEvent #2539

plafer opened this issue Aug 8, 2022 · 0 comments · Fixed by #2542
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented Aug 8, 2022

IbcEvent::height() doesn't belong in the IbcEvent. This field was only tacked on IbcEvent for relayer purposes. We should instead create a IbcEventWithHeight struct in the relayer that tracks extra height data.

struct IbcEventWithHeight {
    event: IbcEvent,
    height: Height,
}

Contributes towards cosmos/ibc-rs#11.

@adizere adizere added this to the v1.1 milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants