Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating telemetry changed the metric names #3326

Closed
5 tasks
Tracked by #3217
ljoss17 opened this issue May 11, 2023 · 1 comment · Fixed by #3343
Closed
5 tasks
Tracked by #3217

Updating telemetry changed the metric names #3326

ljoss17 opened this issue May 11, 2023 · 1 comment · Fixed by #3343
Labels
A: bug Admin: something isn't working I: telemetry Internal: related to Telemetry & metrics

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented May 11, 2023

Summary of Bug

Most of the metrics now have a _total suffix, which can cause existing Grafana dashboards to not display the metrics anymore unless they are updated. This might be due to the update of telemetry versions:

  • opentelemetry from v0.18.0 to v0.19.0
  • opentelemetry_api from v0.18.0 to v0.19.0
  • opentelemetry_sdk from v0.18.0 to v0.19.0
  • opentelemetry-prometheus from v0.11.0 to 0.12.0

Version

Current master, commit dbd9d70ce95b0392795774c64bee340439f7de7d

Acceptance Criteria

  • Document this breaking change
    or
  • If possible, update the telemetry to keep the previous metric denominations (without the suffixed _total)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes May 11, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 📥 Todo in Hermes May 11, 2023
@seanchen1991 seanchen1991 added the I: telemetry Internal: related to Telemetry & metrics label May 11, 2023
@seanchen1991 seanchen1991 mentioned this issue May 11, 2023
Closed
3 tasks
@romac romac added the A: bug Admin: something isn't working label May 12, 2023
@ljoss17
Copy link
Contributor Author

ljoss17 commented May 15, 2023

The change comes from opentelemtry-prometheus v0.12.0, https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-prometheus/CHANGELOG.md#v0120

@ljoss17 ljoss17 mentioned this issue May 16, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in Hermes May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working I: telemetry Internal: related to Telemetry & metrics
Projects
Hermes
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document metric label updates informalsystems/hermes
3 participants
@romac @seanchen1991 @ljoss17