Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes should panic on overflow #3392

Closed
5 tasks
romac opened this issue Jun 5, 2023 · 0 comments · Fixed by #3390
Closed
5 tasks

Hermes should panic on overflow #3392

romac opened this issue Jun 5, 2023 · 0 comments · Fixed by #3390
Assignees
Labels
O: reliability Objective: cause to improve trustworthiness and consistent performing
Milestone

Comments

@romac
Copy link
Member

romac commented Jun 5, 2023

Summary

Overflow often are a symptom of a logic error, and while they raise panics in debug mode (ie. in tests), they may still occur in release mode (ie. in production) and silently lead to incorrect and hard to debug behavior.

We should therefore enable overflow checks in release mode to have the relayer panic on overflows, so that we may then fix the logic bug behind it.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added the O: reliability Objective: cause to improve trustworthiness and consistent performing label Jun 5, 2023
@romac romac added this to the v1.5.1 milestone Jun 5, 2023
@romac romac self-assigned this Jun 5, 2023
@romac romac added this to Hermes Jun 5, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jun 5, 2023
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: reliability Objective: cause to improve trustworthiness and consistent performing
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant