Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relayer V0 command: configuration and parameters #346

Closed
5 of 11 tasks
adizere opened this issue Oct 28, 2020 · 0 comments · Fixed by #351
Closed
5 of 11 tasks

relayer V0 command: configuration and parameters #346

adizere opened this issue Oct 28, 2020 · 0 comments · Fixed by #351
Assignees
Labels
I: CLI Internal: related to the relayer's CLI
Milestone

Comments

@adizere
Copy link
Member

adizere commented Oct 28, 2020

Crate

relayer and relayer-cli

Summary

This is the first iteration on making v0 relayer command more concrete. Currently, the v0 command is almost entirely stubbed, and there is a lot of uncertainty about the types therein.

This work should tackle:

  • instantiate ChainRuntime by passing the configuration
  • making the types more concrete and filling any gaps or missing pieces, in particular for ChainRuntime, ForeignClient, and ForeignClientConfig.
  • bridge the v0 infrastructure with the create_client command -- in this first version we'll probably leave the original create_client implementation untouched (for backwards compatibility with the start command) and simply copy most of that functionality into a new module.
  • consider some restructuring, e.g, put ChainRuntime in its own module
  • revisit ADR 004 as we go along with this implementation
  • _ ... to be decided_

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added the I: CLI Internal: related to the relayer's CLI label Oct 28, 2020
@adizere adizere added this to the v0.0.5 milestone Oct 28, 2020
@adizere adizere self-assigned this Oct 28, 2020
@romac romac self-assigned this Oct 29, 2020
@adizere adizere mentioned this issue Nov 9, 2020
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants