Hermes is dropping supporting headers when assembling messages from the operational data

[romac]

Summary of Bug

OperationalData::assemble_msgs is discarding the client updates for the supporting headers returned by the light client when assembling messages to relay from the operational data.

hermes/crates/relayer/src/link/operational_data.rs

Lines 169 to 180 in 7ec23d1

	// Fetch the client update message. Vector may be empty if the client already has the header
	// for the requested height.
	let mut client_update_opt = match self.target {
	OperationalDataTarget::Source => {
	relay_path.build_update_client_on_src(update_height)?
	}
	OperationalDataTarget::Destination => {
	relay_path.build_update_client_on_dst(update_height)?
	}
	};
	client_update_opt.pop()

As can be seen above, it only keeps the last client update which corresponds to the latest height at which we want to update the client to. But if the light client needed to do bisection to verify that header from the current trusted state, then that client update would be rejected on chain, as the chain needs the supporting headers to perform verification in case of bisection.

It should instead prepend all the client updates returned by build_update_client_on_src/dst.

Version

master

Steps to Reproduce

Acceptance Criteria

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate milestone (priority) applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned