Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable listen command with pull event source #3501

Closed
5 tasks
Tracked by #3217
romac opened this issue Jul 25, 2023 · 0 comments · Fixed by #3502
Closed
5 tasks
Tracked by #3217

Enable listen command with pull event source #3501

romac opened this issue Jul 25, 2023 · 0 comments · Fixed by #3502
Assignees
@romac
Labels
I: CLI Internal: related to the relayer's CLI O: new-feature Objective: cause to add a new feature or support
Milestone
v1.7

Comments

@romac
Copy link
Member

romac commented Jul 25, 2023

Problem Definition

The listen command currently only works with event_source.mode = 'push' but not with pull.

Proposal

Add support for event_source.mode = 'poll' to the listen command.

Acceptance Criteria

The listen command works with event_source.mode = 'poll'.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added O: new-feature Objective: cause to add a new feature or support I: CLI Internal: related to the relayer's CLI labels Jul 25, 2023
@romac romac added this to the v1.7 milestone Jul 25, 2023
@romac romac self-assigned this Jul 25, 2023
@romac romac added this to Hermes Jul 25, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jul 25, 2023
@romac romac mentioned this issue Jul 25, 2023
Merged
7 tasks
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 🔖 Needs review in Hermes Jul 26, 2023
@seanchen1991 seanchen1991 mentioned this issue Jul 26, 2023
Closed
3 tasks
@github-project-automation github-project-automation bot moved this from 🔖 Needs review to ✅ Done in Hermes Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
I: CLI Internal: related to the relayer's CLI O: new-feature Objective: cause to add a new feature or support
Projects
Hermes
Status: ✅ Done
Milestone
v1.7
Development

Successfully merging a pull request may close this issue.

Enable listen command with pull event source informalsystems/hermes
1 participant
@romac