Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracing directives on runtime #3564

Closed
5 tasks
Tracked by #3217
ljoss17 opened this issue Aug 25, 2023 · 0 comments · Fixed by #3565
Closed
5 tasks
Tracked by #3217

Update tracing directives on runtime #3564

ljoss17 opened this issue Aug 25, 2023 · 0 comments · Fixed by #3565
Assignees
Labels
O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Aug 25, 2023

Summary

Currently in order to change the log level of Hermes, the instance needs to be restarted. tracing has a reload_handle allowing directive updates for the logs. https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.SubscriberBuilder.html#method.with_filter_reloading

Proposal

Set up an endpoint which listens to tracing directives, https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/struct.EnvFilter.html#directives, and update the logs displayed.

Add some CLIs to facilitate updating the tracing directives.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 self-assigned this Aug 25, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Aug 25, 2023
@seanchen1991 seanchen1991 added O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Aug 31, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 🏗 In progress in Hermes Aug 31, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Hermes Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants