Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change clear_interval setting to be defined per chain #3691

Closed
5 tasks
sryps opened this issue Nov 8, 2023 · 1 comment · Fixed by #3693
Closed
5 tasks

Change clear_interval setting to be defined per chain #3691

sryps opened this issue Nov 8, 2023 · 1 comment · Fixed by #3693
Assignees
Milestone

Comments

@sryps
Copy link

sryps commented Nov 8, 2023

Summary

I am proposing the clear_interval be set per chain in the chain config section of config.toml

Problem Definition

When relaying between a chain with a 6 second block time and a chain with a 1 second block time the clear interval can happen either too often and hurt performance of the relaying or not very often which isn't good for health of the channel.

Example Noble<>DYDX
if clear_interval is set to default 100:

  • Noble clears packets every ~10min
  • DYDX clears packets every 100seconds

if clear_interval is set to 500:

  • Noble clears packets every ~50min
  • DYDX clears packets every 8.3min

if clear_interval is set to 1000:

  • Noble clears packets every ~1.6hours
  • DYDX clears packets every 16.6min

The clear_interval happens X times more often on one chain vs the other when block speeds vary.

Not sure it's possible, but I guess another solution would be to use an amount of time vs every X block..clear_interval = 30min

I feel it would be beneficial to set the clear_interval per chain so there's more granular control over the occurrence rate.

Acceptance Criteria

clear_interval can be set for each chain in config.toml.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Nov 8, 2023
@romac romac added this to the v1.7.1 milestone Nov 8, 2023
@romac romac changed the title clear_interval to be set in chain config Change clear_interval setting to be defined per chain Nov 8, 2023
@romac
Copy link
Member

romac commented Nov 8, 2023

@ljoss17 Let's do this but keep the top-level clear_interval for now, and override it with the per-chain clear_interval if present.

@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants