Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration to ignore packets with memo or receiver fields too big #3766

Closed
5 tasks
Tracked by #3750
ljoss17 opened this issue Jan 10, 2024 · 0 comments · Fixed by #3765
Closed
5 tasks
Tracked by #3750

Add a configuration to ignore packets with memo or receiver fields too big #3766

ljoss17 opened this issue Jan 10, 2024 · 0 comments · Fixed by #3765
Milestone

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Jan 10, 2024

Summary

Some ICS20 packets might have very big memo and/or receiver fields which could cause issues. IBC-GO v8 introduces a maximum limit for these fields: https://github.com/cosmos/ibc-go/blob/04e14a7079e18323c64d4e00e12cf77708d24701/modules/apps/transfer/types/msgs.go#L15.

Hermes should be able to configure a limit used to filter packets depending on the size of the memo and receiver fields.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jan 10, 2024
@ancazamfir ancazamfir moved this from 🩹 Triage to 🏗 In progress in Hermes Jan 11, 2024
@romac romac added this to the v1.9 milestone Jan 16, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Hermes Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants