Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus metric for gRPC txs simulations errors #3845

Closed
5 tasks
freak12techno opened this issue Feb 10, 2024 · 2 comments · Fixed by #3846
Closed
5 tasks

Add Prometheus metric for gRPC txs simulations errors #3845

freak12techno opened this issue Feb 10, 2024 · 2 comments · Fixed by #3846
Milestone

Comments

@freak12techno
Copy link
Contributor

Summary

It'd be really awesome if Prometheus would expose a metric that displays the number of errors of encountered gRPC transaction similation errors, to build alerts upon it.

Problem Definition

I am currently getting a lot of errors like this one in my logs:

Feb 10 15:00:54 monitoring-logging hermes[3533022]: 2024-02-10T14:00:54.862596Z ERROR ThreadId(25) spawn:chain{chain=cosmoshub-4}:client{client=07-tendermint-259}:connection{connection=connection-257}:channel{channel=channel-141}:worker.packet.cmd{src_chain=cosmoshub-4 src_port=transfer src_channel=channel-141 dst_chain=osmosis-1}:relay{odata=0b01290a ->Destination @4-19097544; len=1}:send_messages_and_wait_check_tx{chain=osmosis-1 tracking_id=0b01290a}:send_tx_with_account_sequence_retry{chain=osmosis-1 account.sequence=984}:estimate_gas: failed to simulate tx. propagating error to caller: gRPC call `send_tx_simulate` failed with status: status: Unknown, message: "spendable balance 2950583uosmo is smaller than 3000001uosmo: insufficient funds: insufficient funds [osmosis-labs/osmosis/v22/x/txfees/keeper/feedecorator.go:294] With gas wanted: '300000000' and gas used: '913739' ", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "x-cosmos-block-height": "13725151"} }

Not sure yet what's the reason, that's another discussion topic out of the scope of this feature request, but it would be nice if there would be a way to 1) see this happening via a Grafana dashboard that takes data from Prometheus set up to scrape Hermes metrics, and 2) build alerts from this metrics to know about such things in advance.

Proposal

Add a Prometheus metric, as a counter, displaying how many errors happened when simulating a transaction. The labels can be a chain, and probably the error type/status/whether the error is recoverable or not.

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Feb 10, 2024
@freak12techno freak12techno changed the title Add Prometheus metric for gRPC txs similations error Add Prometheus metric for gRPC txs similations errors Feb 10, 2024
@freak12techno
Copy link
Contributor Author

(I can add it myself it it's possible, always wanted to play with Rust a bit lol)

@romac
Copy link
Member

romac commented Feb 10, 2024

Great idea! We have our hands a bit full with other core development tasks at the moment but we'd happily accept and shepard a PR, as you kindly suggest.

@romac romac added this to the v1.8.1 milestone Feb 20, 2024
@romac romac changed the title Add Prometheus metric for gRPC txs similations errors Add Prometheus metric for gRPC txs simulations errors Feb 20, 2024
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants