Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat_mode isn't set properly in subscribe.pull mode #3910

Closed
5 tasks
tkxkd0159 opened this issue Mar 22, 2024 · 0 comments · Fixed by #3911
Closed
5 tasks

compat_mode isn't set properly in subscribe.pull mode #3910

tkxkd0159 opened this issue Mar 22, 2024 · 0 comments · Fixed by #3911
Labels
A: bug Admin: something isn't working
Milestone

Comments

@tkxkd0159
Copy link
Contributor

Summary of Bug

When we uses pull event source mode, hermes listen cannot set compat_mode properly. So It fails to unmarshal block_results if that chain uses 0.34 CometBFT.

Version

b076784

Steps to Reproduce

  1. Set event source mode as pull
  2. hermes listen --chain <chain-id>
  3. Send any tx and show the parsing error

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Mar 22, 2024
@romac romac added the A: bug Admin: something isn't working label Mar 22, 2024
@romac romac added this to the v1.9 milestone Mar 22, 2024
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants