Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dynamic Gas Fees #4000

Closed
5 tasks
ljoss17 opened this issue May 27, 2024 · 0 comments · Fixed by #4004
Closed
5 tasks

Improve Dynamic Gas Fees #4000

ljoss17 opened this issue May 27, 2024 · 0 comments · Fixed by #4004
Assignees

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented May 27, 2024

Summary

The current version of Hermes, v1.8.2, is only compatible with Osmosis dynamic gas fees.
With Skip's FeeMarket https://github.com/skip-mev/feemarket the Hermes implementation needs to be more flexible.

Proposition

The current implementation uses a hardcoded endpoint, https://github.com/informalsystems/hermes/blob/v1.8.2/crates/relayer/src/chain/cosmos/eip_base_fee.rs#L18. This would need to be a configurable endpoint.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant