Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules: Fix panic in conn open try when no connection id is provided #626

Closed
5 tasks
vitorenesduarte opened this issue Feb 9, 2021 · 1 comment · Fixed by #615
Closed
5 tasks

modules: Fix panic in conn open try when no connection id is provided #626

vitorenesduarte opened this issue Feb 9, 2021 · 1 comment · Fixed by #615

Comments

@vitorenesduarte
Copy link
Contributor

Crate

modules

Summary of Bug

Currently, a conn open try can only succeed if some previous_connection_id is provided in the MsgConnectionOpenTry:
https://github.com/informalsystems/ibc-rs/blob/b1b9dac6132a2fd2a86fa1c6f0179f47db3e3454/modules/src/ics03_connection/msgs/conn_open_try.rs#L26-L35
However, to have a valid previous_connection_id, one has to have a successful conn open try. This circular dependency makes it so that it's never possible to have successful conn open try.

Version

277426e

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@vitorenesduarte vitorenesduarte mentioned this issue Feb 9, 2021
Merged
5 tasks
@romac
Copy link
Member

romac commented Feb 9, 2021

Fixed in #615

@romac romac closed this as completed Feb 9, 2021
@andrey-kuprianov andrey-kuprianov mentioned this issue Sep 28, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panic in conn open try when no connection id is provided informalsystems/hermes
2 participants
@romac @vitorenesduarte