Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send MsgAcknowledgment if channel is closed #675

Closed
5 tasks done
ancazamfir opened this issue Feb 16, 2021 · 0 comments · Fixed by #795
Closed
5 tasks done

Don't send MsgAcknowledgment if channel is closed #675

ancazamfir opened this issue Feb 16, 2021 · 0 comments · Fixed by #795
Assignees
Milestone

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Feb 16, 2021

Crate

relayer

Summary of Bug

With a closed channel the MsgAcknowledgment will be rejected by the chain. Instead of sending (and retrying) it, the relayer should check the channel state on the destination chain and drop the message (there is no acknowledgment timeout on close or graceful channel shutdown procedure currently specified in IBC).

Version

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added this to the v0.1.1 milestone Feb 16, 2021
@ancazamfir ancazamfir self-assigned this Feb 16, 2021
@adizere adizere modified the milestones: v0.1.1, 03.2021 Feb 18, 2021
@romac romac closed this as completed in #795 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants