Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing port information in hermes query channels #840

Closed
5 tasks
ancazamfir opened this issue Apr 22, 2021 · 0 comments · Fixed by #861
Closed
5 tasks

Missing port information in hermes query channels #840

ancazamfir opened this issue Apr 22, 2021 · 0 comments · Fixed by #861
Assignees
Labels
I: CLI Internal: related to the relayer's CLI
Milestone

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Apr 22, 2021

Crate

relayer-cli

Summary of Bug

While testing ICS27 packets I noticed that hermes query channels.. returns the list of channel IDs but without the ports,
while the hermes query channel end... CLI that we use to get the details of a given channel requires both the channel and port IDs.

Version

Steps to Reproduce

Acceptance Criteria

hermes query channels.. should return both channel and port. While current SDK impl generates unique channel IDs, the channel ID can be unique per port.
This can also be seen in pub struct IdentifiedChannel, see the last two fields that identify the channel (compared with pub struct Channel above in the same file) https://github.com/informalsystems/ibc-rs/blob/75d4dd81262cab979b1bf286b0b462297825ab65/proto/src/prost/ibc.core.channel.v1.rs#L43-L48


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added this to the 04.2021 milestone Apr 22, 2021
@adizere adizere added the I: CLI Internal: related to the relayer's CLI label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants