Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny uses of unwrap in non-test code (first pass) #871

Closed
5 tasks done
adizere opened this issue Apr 29, 2021 · 0 comments · Fixed by #850
Closed
5 tasks done

Deny uses of unwrap in non-test code (first pass) #871

adizere opened this issue Apr 29, 2021 · 0 comments · Fixed by #850
Assignees
@adizere
Labels
E: gravity External: related to Gravity DEX O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone
05.2021

Comments

@adizere
Copy link
Member

adizere commented Apr 29, 2021 •
edited
Loading

Crate

all

Acceptance Criteria

Enable #![cfg_attr(not(test), deny(clippy::unwrap_used))]

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the 05.2021 milestone Apr 29, 2021
@adizere adizere added O: new-feature Objective: cause to add a new feature or support in progress O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Apr 29, 2021
@adizere adizere mentioned this issue Apr 29, 2021
Merged
2 tasks
@romac romac added the E: gravity External: related to Gravity DEX label Apr 29, 2021
@romac romac mentioned this issue May 6, 2021
Merged
5 tasks
@ancazamfir ancazamfir mentioned this issue May 6, 2021
Merged
26 tasks
@adizere adizere changed the title Deny uses of unwrap in non-test code Deny uses of unwrap in non-test code (first pass_ May 25, 2021
@adizere adizere changed the title Deny uses of unwrap in non-test code (first pass_ Deny uses of unwrap in non-test code (first pass May 25, 2021
@adizere adizere changed the title Deny uses of unwrap in non-test code (first pass Deny uses of unwrap in non-test code (first pass) May 25, 2021
@adizere adizere mentioned this issue May 25, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
E: gravity External: related to Gravity DEX O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Milestone
05.2021
Development

Successfully merging a pull request may close this issue.

Deny uses of .unwrap() in non-test code (first pass) informalsystems/hermes
2 participants
@romac @adizere